Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding hashes to system tab URLs #5535

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Adding hashes to system tab URLs #5535

wants to merge 4 commits into from

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Nov 25, 2024 •
edited
Loading

Closes LA-167

Description Of Changes

Adds URL "fragments" for the different tabs in the system page. This allows us to deep-link into specific tabs. It also allows us to navigate back to a specific system tab if needed.

Code Changes

  • Moved some logic away from the systems page and into useSystemFormTabs.tsx

Steps to Confirm

  1. Navigate between the different tabs in the system page, verify the URL updates
  2. Copy one of the URLs and verify you can navigate directly to that tab by following the URL
    tabs

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Nov 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 6:17pm

@cypress Cypress
Copy link

cypress bot commented Nov 25, 2024 •
edited
Loading

fides    Run #11171

Run Properties:  status check passed Passed #11171  •  git commit c8d4a71490 ℹ️: Merge 767194be4c8a6aa1a74371665710ef23b9288c45 into f4ad7467bd77fc8bafc2eaa54b06...
Project fides
Branch Review refs/pull/5535/merge
Run status status check passed Passed #11171
Run duration 00m 57s
Commit git commit c8d4a71490 ℹ️: Merge 767194be4c8a6aa1a74371665710ef23b9288c45 into f4ad7467bd77fc8bafc2eaa54b06...
Committer Adrian Galvan
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

galvana
galvana commented Nov 25, 2024
View reviewed changes
clients/admin-ui/src/features/system/hooks/useSystemFormTabs.tsx
@@ -31,6 +35,38 @@ import {
import SystemInformationForm from "~/features/system/SystemInformationForm";
import { SystemResponse } from "~/types/api";

const SYSTEM_TABS = {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formalizing this a bit so we don't have so many magic numbers and strings floating around

@galvana galvana marked this pull request as ready for review November 25, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eastandwestwind eastandwestwind Awaiting requested review from eastandwestwind

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@galvana